[wp-trac] [WordPress Trac] #50686: UI issue on nav-menus.php

[WordPress Trac]

#50686: UI issue on nav-menus.php
-------------------------------------+-------------------------------------
 Reporter:  dilipbheda               |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.6
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch needs-refresh                |  css, administration
-------------------------------------+-------------------------------------
Changes (by sabernhardt):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch needs-refresh
 * focuses:  ui, accessibility, javascript, css, administration => ui,
     accessibility, css, administration


Comment:

 @helen Thanks for trying the other approach.

 With the patch, I noticed that these did not receive the border when one
 is invalid:
 * post schedule (classic editor) - date/time fields
 * page schedule (classic editor) - date/time fields

 These fields do show the border when left empty:
 * new user - both username and email address inputs
 * new menu - name
 * menu custom link - both URL and link text
 * new category - name
 * new tag - name
 * edit category - name
 * edit tag - name

 I don't mind that the latest patch applies the red border around the
 custom link text input, though technically it is not required (that's why
 the previous patch had the second `:not()`). If a URL is submitted with
 empty custom text, the "Menu Item" fallback link text is not very helpful
 anyway.

 Due to the time, this probably should be punted. However, if one `:not()`
 is acceptable, I could create a quick patch to add the `required`
 attribute to the first patch and let the custom link text receive the
 border when the URL is empty.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50686#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform