[wp-trac] [WordPress Trac] #50801: A filter for wp_get_attachment_image() html output

[WordPress Trac]

#50801: A filter for wp_get_attachment_image() html output
-------------------------------------------------+-------------------------
 Reporter:  prionkor                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.6
Component:  Media                                |     Version:  5.4.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note                                           |
-------------------------------------------------+-------------------------
Changes (by antpb):

 * keywords:  has-patch has-unit-tests needs-dev-note commit => has-patch
     has-unit-tests needs-dev-note


Comment:

 I made some changes to the patch that I'd like to get some outside looks
 at. I've been talking this through with @garrett-eclipse and we landed on
 the below proposed patch. I've removed the @since in the parent function's
 doc block because we are covering the documentation in the new filter.

 I've also matched the passed attributes for the parent function in the new
 filter so folks can override any of them. Happy to hear any feedback on
 that.

 I'm removing commit only because I don't want it to be committed before we
 all agree this approach is best. I'm also blocked at the moment by some
 local tests failing due to an unrelated change here:
 https://core.trac.wordpress.org/ticket/49558.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50801#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform