[wp-trac] [WordPress Trac] #51513: Rename 'wp_is_application_passwords_available' filter and function
WordPress Trac
noreply at wordpress.org
Tue Oct 20 03:04:50 UTC 2020
#51513: Rename 'wp_is_application_passwords_available' filter and function
----------------------------+---------------------
Reporter: SergeyBiryukov | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.6
Component: REST API | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
----------------------------+---------------------
Comment (by TimothyBlynJacobs):
> That would be more consistent with other filters. I realize that
"Application Passwords" is the name of the feature, but without that
context "is" looks a bit weird to me in these names.
I guess to me `wp_is_application_passwords_available` reads like the
question in English "Is application passwords available?". To me that
isn't unclear. Whereas "Application passwords available?" reads like a
disjointed question.
> Is it for application passwords being available for the user, but not
necessarily enabled?
It is for this. The code doesn't look to see if the user has any app
passwords created.
> So it seems like wp_application_passwords_enabled_for_user() would be a
more accurate name?
IMO the description should be updated.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51513#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list