[wp-trac] [WordPress Trac] #42063: Media: Indicate if image is used as a site option
WordPress Trac
noreply at wordpress.org
Tue Oct 20 01:09:08 UTC 2020
#42063: Media: Indicate if image is used as a site option
----------------------------------------------+----------------------------
Reporter: melchoyce | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.6
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit | Focuses: ui,
| administration
----------------------------------------------+----------------------------
Changes (by garrett-eclipse):
* keywords: has-patch has-screenshots needs-refresh => has-patch has-
screenshots commit
Comment:
Revisiting after I attempted to make a refresh...
Attempting to use `_media_states( $attachement, false );` I found the
media template doesn't support HTML as it encodes it and viewing in the
modal the label is bold so we don't so much care to do the same for the
list of states. And looking at the class `post-state` is appropriate as
the existing usage of `_media_states` is in the list table so it's just
adopting that styling.
In short... @helen's previous PR there looks great and I would almost
suggest keeping the echo as with the post_states method it was applied in
multiple locations through follow-up tickets after the initial change so I
would expect similar here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42063#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list