[wp-trac] [WordPress Trac] #19879: Better caching for get_dirsize

[WordPress Trac]

#19879: Better caching for get_dirsize
-------------------------------------------------+-------------------------
 Reporter:  batmoo                               |       Owner:  helen
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.6
Component:  Filesystem API                       |     Version:  3.3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note has-unit-   |     Focuses:  multisite,
  tests needs-testing dev-feedback               |  performance
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * type:  enhancement => task (blessed)
 * resolution:  fixed =>


Comment:

 Reopening for some documentation fixes and testing.

 1. I believe this should be renamed to `clean_dirsize_cache()`, for
 consistency with other functions of a similar purpose:
  * `clean_bookmark_cache()`
  * `clean_category_cache()`
  * `clean_comment_cache()`
  * `clean_site_details_cache()`
  * `clean_network_cache()`
  * `clean_blog_cache()`
  * `clean_post_cache()`
  * `clean_attachment_cache()`
  * `clean_object_term_cache()`
  * `clean_term_cache()`
  * `clean_taxonomy_cache()`
  * `clean_user_cache()`

 2. As noted above, I'm not sure `normalize_dirsize_cache_path()` is needed
 for just two instances, seems a bit too specific for just two lines of
 code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/19879#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform