[wp-trac] [WordPress Trac] #19879: Better caching for get_dirsize
WordPress Trac
noreply at wordpress.org
Mon Oct 19 19:32:01 UTC 2020
#19879: Better caching for get_dirsize
-------------------------------------------------+-------------------------
Reporter: batmoo | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.6
Component: Filesystem API | Version: 3.3.1
Severity: normal | Resolution:
Keywords: has-patch needs-dev-note has-unit- | Focuses: multisite,
tests needs-testing dev-feedback | performance
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):
* keywords: has-patch dev-feedback needs-dev-note has-unit-tests => has-
patch needs-dev-note has-unit-tests needs-testing dev-feedback
Comment:
Notes from today's scrub:
Per @helen:
>I did not get any feedback from anybody that they’re actually interacting
with any hooks in the area, so it’s probably a matter of committing and
seeing if anything breaks at this point…
Per @SergeyBiryukov:
>I'm not sure `normalize_dirsize_cache_path()` is needed for just two
instances, I would look into using `wp_normalize_path()` and getting rid
of `DIRECTORY_SEPARATOR`, as we don't use that anywhere else for similar
actions. I can take a closer look and test on Windows.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/19879#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list