[wp-trac] [WordPress Trac] #50538: WP_Comments_List_Table should not show views that have a count of 0

[WordPress Trac]

#50538: WP_Comments_List_Table should not show views that have a count of 0
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  refresh 2nd-opinion                            |  administration
-------------------------------------------------+-------------------------
Changes (by helen):

 * keywords:  has-screenshots has-patch needs-refresh => has-screenshots
     has-patch needs-refresh 2nd-opinion
 * milestone:  5.6 => Awaiting Review


Comment:

 I am punting this from 5.6 and I would actually recommend closing. There
 are two main reasons for this:

 * The code required to make this work is a textbook example of technical
 debt - it is unpleasant to look at and it's going to be very unpleasant to
 maintain into the future.
 * I don't agree that this is usably better for comments specifically. I
 can buy that consistency is good for many other 0-count view filters, but
 for comments the entire model is pretty different and you have
 interactions with keyboard shortcuts and mass moderation, etc. so my view
 on this is that knowing what states are even possible is actually
 important here.

 The combination of those two points and that we're looking at beta 1
 tomorrow makes this a punt for now and a recommended closure from me :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50538#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform