[wp-trac] [WordPress Trac] #51293: Add $option Parameter to wp_send_json, wp_send_json_success and wp_send_json_error
WordPress Trac
noreply at wordpress.org
Sat Oct 17 20:37:54 UTC 2020
#51293: Add $option Parameter to wp_send_json, wp_send_json_success and
wp_send_json_error
------------------------------+-----------------------------
Reporter: eroraghav | Owner: SergeyBiryukov
Type: feature request | Status: reviewing
Priority: normal | Milestone: 5.6
Component: General | Version: 5.5.1
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+-----------------------------
Changes (by garrett-eclipse):
* keywords: has-patch => has-patch commit
Comment:
Thanks for the ticket & patch @eroraghav, and refresh @hareesh-pillai.
Testing it looks good to me, applies clean and all existing tests run
nicely. I did make one minor change in
[https://core.trac.wordpress.org/attachment/ticket/51293/51293.2.diff
51293.2.diff] to fix the CS issue with the @param descriptions as they
should all aligned off of the longest param.
@SergeyBiryukov would you care to give it a review/test, I wasn't sure if
the change warranted unit tests?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51293#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list