[wp-trac] [WordPress Trac] #39097: Links in embeds can't be opened in a new tab

[WordPress Trac]

#39097: Links in embeds can't be opened in a new tab
-------------------------------------+-----------------------------
 Reporter:  smerriman                |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.6
Component:  Embeds                   |     Version:  4.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility
-------------------------------------+-----------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch commit => has-patch needs-testing


Comment:

 Testing the second diff worked as @SergeyBiryukov indicated and was just
 going to update the spelling of `catched` => `caught` but saw other
 implementations also covering the altKey and ShiftKey so looked into them
 and found they're valid cases as well so added them in
 [https://core.trac.wordpress.org/attachment/ticket/39097/39097.3.diff
 39097.3.diff].
 altKey (option key on mac) will 'save the link as'.
 shiftKey will 'open a new window'.

 Sorry to remove the commit but would like my change tested on Windows as
 well since I only have a Mac.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39097#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform