[wp-trac] [WordPress Trac] #39097: Links in embeds can't be opened in a new tab

[WordPress Trac]

#39097: Links in embeds can't be opened in a new tab
------------------------------+-----------------------------
 Reporter:  smerriman         |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  5.6
Component:  Embeds            |     Version:  4.4
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  accessibility
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-testing has-patch => has-patch commit
 * milestone:  Future Release => 5.6


Comment:

 Testing this again, [attachment:"39097.diff"] mostly works, but needs some
 adjustment to check for the correct modifiers.

 [attachment:"39097.2.diff"] works as expected. To test:
 1. `npm run build`.
 2. Embed a post on your local install in another post.
 3. Try Ctrl/Cmd + click on any link in the embed iframe. The link should
 open in a new tab.

 This only affects Ctrl/Cmd + click. Right-clicking a link in the embed
 iframe and then selecting "Open link in a new tab" already works in my
 testing in both Chrome and Firefox, so it doesn't look like any changes
 are needed for that.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39097#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform