[wp-trac] [WordPress Trac] #51555: Privacy Page: Does it need to be a Page? Also, is a warning an error?

[WordPress Trac]

#51555: Privacy Page: Does it need to be a Page? Also, is a warning an error?
----------------------------+---------------------------------
 Reporter:  bkjproductions  |       Owner:  garrett-eclipse
     Type:  enhancement     |      Status:  reviewing
 Priority:  normal          |   Milestone:  Future Release
Component:  Privacy         |     Version:  4.9.6
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  ui, administration
----------------------------+---------------------------------
Changes (by garrett-eclipse):

 * status:  new => reviewing
 * focuses:  privacy => ui, administration
 * owner:  (none) => garrett-eclipse
 * version:  5.5.1 => 4.9.6
 * milestone:  Awaiting Review => Future Release
 * keywords:   => needs-patch
 * type:  defect (bug) => enhancement


Comment:

 Thanks for the ticket @bkjproductions.

 1. Providing support for alternate post types.
 Seems like a nice improvement to me, let's use this ticket to work on that
 for a future release.
 If you need to accomplish this currently the dropdown uses the
 `wp_dropdown_pages` which then uses `get_pages` but it also calls the
 `wp_dropdown_pages` filter. So technically to support alternate post types
 now you can filter the output there when the `$parsed_args` `name` is set
 to `page_for_privacy_policy` and replace the dropdown options with a list
 of all posts of any type through using `get_posts` and your desired post
 types. The output of that filter function would be the full select with
 the options you want, following existing code from `wp_dropdown_pages`.

 2. Alternate privacy content location, such as popups or external sites.
 This was previously raised as a text field you could input any URL for
 your policy for an alternate case in #44201. That was closed as `wontfix`
 by @johnbillion as there is an existing filter to achieve that with
 `privacy_policy_url`;
 https://developer.wordpress.org/reference/hooks/privacy_policy_url/
 The GUI part was deemed plugin territory for now but will raise with the
 team for further discussion.

 3. Bug: warning notice shouldn't use error styling.
 This was previously reported in #50766 and I'm happy to say was fixed in
 5.6 (commit [48906]) which will be going into Beta on the 20th.

 Hope that helps with you current implementation and we'll revisit the
 enhancement request in a future version.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51555#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform