[wp-trac] [WordPress Trac] #42063: Media: Indicate if image is used as a site option

[WordPress Trac]

#42063: Media: Indicate if image is used as a site option
----------------------------------------------+----------------------------
 Reporter:  melchoyce                         |       Owner:  (none)
     Type:  enhancement                       |      Status:  new
 Priority:  normal                            |   Milestone:  5.6
Component:  Media                             |     Version:
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:  ui,
                                              |  administration
----------------------------------------------+----------------------------

Comment (by helen):

 I moved this over to https://github.com/WordPress/wordpress-
 develop/pull/611 for tests to run and to get used to the PR workflow :)

 I have two thoughts here before committing:

 1. I would like the string `Current state:` to say `Used as:` instead.
 Both are a little misleading but the latter is somewhat less so, as you
 have both `Header Image` and `Current Header Image` (and the same for
 backgrounds). This is reflected in the GitHub pull request.
 2. I'm not sure (or rather @markjaquith is not sure) that we should be
 adding the `$echo` param to `_media_states()` in this patch because it is
 not going to be used anywhere in core, and it's an internal function so it
 doesn't need to appeal to a wider use case. This is not yet reflected in
 the pull request.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42063#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform