[wp-trac] [WordPress Trac] #50401: Tests: Move tests into Github Actions

WordPress Trac noreply at wordpress.org
Fri Oct 16 00:10:08 UTC 2020


#50401: Tests: Move tests into Github Actions
------------------------------+--------------------------
 Reporter:  whyisjake         |       Owner:  desrosj
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  5.6
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  performance
------------------------------+--------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-testing => has-patch
 * milestone:  Future Release => 5.6


Comment:

 Been monitoring this with @helen the last few hours. There are a few
 things that we've noticed.

 First, the [https://github.com/WordPress/wordpress-
 develop/actions?query=workflow%3A%22Welcome+New+Contributors%22 "Welcome"
 workflow] is unable to comment on the PR. It seems this is being caused by
 some access issues. It seems this can be solved by using
 `pull_request_target` as the event instead of `pull_request`. More info
 can be found on the [https://github.blog/2020-08-03-github-actions-
 improvements-for-fork-and-pull-request-workflows/#improvements-for-public-
 repository-forks GitHub Blog].

 The second issue is that [https://github.com/WordPress/wordpress-
 develop/commit/805351a47879e22a0ec6c26527d04dca40aaf72c cancelled workflow
 runs are considered failures]. This is not ideal because it will appear as
 though the commit associated with the cancelled workflow run introduced a
 problem to the codebase when that may not be true.

 In Travis, builds are placed in a queue among others associated with your
 account/organization. While there is a queue in GitHub Actions, their
 usage model is based on minutes, not concurrent jobs. It's unlikely that
 we'll experience the same bottleneck waiting for jobs to run, so I'm going
 to remove the "Cancel previous runs of this workflow" steps in the PHPUnit
 and E2E test workflows.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50401#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list