[wp-trac] [WordPress Trac] #50686: UI issue on nav-menus.php

[WordPress Trac]

#50686: UI issue on nav-menus.php
-------------------------------------+-------------------------------------
 Reporter:  dilipbheda               |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.6
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch needs-testing                |  javascript, css, administration
-------------------------------------+-------------------------------------
Changes (by helen):

 * keywords:  has-screenshots needs-patch => has-screenshots has-patch
     needs-testing


Comment:

 [attachment:"50686.diff"] is what I think a solution could be given what's
 currently in place. I tested in a few spots and didn't notice any new
 breakage. The basic idea here is that when `.form-invalid` and `.form-
 required` are on the same element, which is the generic case currently in
 places like Edit Category and Add New User, the border continues to be
 applied to any input and elements contained within that element. The new
 addition is nesting `.form-required` inside `.form-invalid`, which this
 patch adds to the nav menu screen, and then applying the border only to
 the `.form-required` element itself.

 The issue on the Edit Category screen where the alert icon is out of place
 turns out to be due to the `p.description` underneath, and the fact that
 we are applying the icon as an `::after` on the `td` instead of the
 `input`. I think that's probably due to not previously being styled as
 inside the input and that you could potentially have multiple
 inputs/selects inside the `td` but it might be more correct to attach that
 icon to the input/select at this point. That would be better addressed in
 a new ticket, however, since it's not actually a component of this
 specific issue.

 Would like a little more testing for any forms with required elements that
 I may have missed before committing this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50686#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform