[wp-trac] [WordPress Trac] #51513: Rename 'wp_is_application_passwords_available' filter and function

WordPress Trac noreply at wordpress.org
Wed Oct 14 07:35:13 UTC 2020


#51513: Rename 'wp_is_application_passwords_available' filter and function
----------------------------+---------------------
 Reporter:  SergeyBiryukov  |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  5.6
Component:  REST API        |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+---------------------

Comment (by ocean90):

 I also think that we should stick to `available` because
 `wp_is_application_passwords_available()` explicitly checks for something
 that needs to exist to make application passwords available. Similar to
 the now deprecated `rest_enabled` filter, we shouldn't use a name which
 promotes that it can only be used to disable application passwords.

 Looking at the UI strings, "Application passwords are not enabled." should
 probably be changed to clarify that the requirements are not satisfied
 which can also be represented by the HTTP status code 501 instead of 500.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51513#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list