[wp-trac] [WordPress Trac] #40351: Term post re-counts scale poorly, are common and difficult to avoid

[WordPress Trac]

#40351: Term post re-counts scale poorly, are common and difficult to avoid
-------------------------------------------------+-------------------------
 Reporter:  mattoperry                           |       Owner:  whyisjake
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.6
Component:  Taxonomy                             |     Version:  4.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing early        |     Focuses:
  needs-dev-note has-unit-tests dev-feedback     |  performance
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 Following the discussion in last week's 0500 UTC dev chat I have done
 further testing.

 PR updates since:

 * further tests: basically putting in to code the tests cases I thought
 of.
 * one minor change to actual code to prevent off-by-X errors.
 * typo fix in Taxonomy class

 I reached out to Boone Gorges via Slack for additional feedback: while
 happy with the code he does have some concern that off-by-one error will
 remain in the database in the event of race conditions due to simultaneous
 updates or propagation delays across database servers.

 I have noticed an issue with taxonomies applying to users or comments:
 deleting the object does not delete the object/term relationship, thus
 causing term counts to be out. I have tested this on both trunk and this
 PR's branch and the problem occurs on both indicating term counts for non-
 post objects may already be out and can not be handled by this ticket.

 I think this is good to go and aim to commit just prior to this week's dev
 chat in two days. If anything else if found between now and then, it can
 be removed from the milestone.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40351#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform