[wp-trac] [WordPress Trac] #51379: Add filter to function email_exists()

WordPress Trac noreply at wordpress.org
Sun Oct 11 02:25:18 UTC 2020


#51379: Add filter to function email_exists()
---------------------------------------------+-----------------------------
 Reporter:  apermo                           |       Owner:  SergeyBiryukov
     Type:  feature request                  |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.6
Component:  Users                            |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch needs-dev-note commit  |     Focuses:
---------------------------------------------+-----------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch dev-feedback needs-dev-note => has-patch needs-dev-
     note commit


Comment:

 The filter itself looks good and applied via trunk. I've updated the patch
 in [https://core.trac.wordpress.org/attachment/ticket/51379/51379.2.diff
 51379.2.diff] to expand upon what 'Email.' in both the filter and the
 function signature. As well introduced a @since description to the
 email_exists function to introduce the new filter to that documentation.

 Concerning the `dev-feedback` I'm going to remove as I concur with the
 comment by @Mista-Flo;
 Replying to [comment:8 Mista-Flo]:
 > Hi there. Well if `username_exists` function has the same filter, then I
 don't see any reason to not add the same kind of filter for `email_exists`
 as well. Patch looks good.

 Marking for commit as everything looks good and my latest patch is just a
 final improvement to the docblock.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51379#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list