[wp-trac] [WordPress Trac] #51493: Type error in wp_xmlrpc_server::_prepare_taxonomy()

[WordPress Trac]

#51493: Type error in wp_xmlrpc_server::_prepare_taxonomy()
-------------------------+-------------------------------------------------
 Reporter:  johnbillion  |      Owner:  (none)
     Type:  defect       |     Status:  new
  (bug)                  |
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  XML-RPC      |    Version:  3.7
 Severity:  normal       |   Keywords:  needs-patch good-first-bug needs-
  Focuses:               |  unit-tests
-------------------------+-------------------------------------------------
 There's a type error in the `wp_xmlrpc_server::_prepare_taxonomy()`
 method.

 Ref: https://core.trac.wordpress.org/browser/tags/5.5.1/src/wp-includes
 /class-wp-xmlrpc-server.php?marks=768-770#L742

 If `$fields` array contains a `menu` element then it tries to read the
 `show_in_menu` property from `$_taxonomy`, but this is an array not an
 object.

 Probably just needs `$_taxonomy` changed to `$taxonomy` but needs testing,
 ideally needs a unit test and steps to reproduce.

 Introduced in [20930].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51493>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform