[wp-trac] [WordPress Trac] #44354: Improve `WP_Privacy_Requests_Table` to manage columns

WordPress Trac noreply at wordpress.org
Fri Oct 9 21:52:56 UTC 2020


#44354: Improve `WP_Privacy_Requests_Table` to manage columns
-------------------------------------------------+-------------------------
 Reporter:  7studio                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  screenshots                                    |  administration
-------------------------------------------------+-------------------------

Comment (by garrett-eclipse):

 Replying to [comment:10 garrett-eclipse]:
 > I've refreshed the patch in
 [https://core.trac.wordpress.org/attachment/ticket/44354/44354.3.diff
 44354.3.diff] to do minor updates to the phpdocs, but also added a
 `return;` to the end of `column_default()` as the list tables do expect a
 return value as it's output in the default list table class here;
 > https://core.trac.wordpress.org/browser/tags/5.5.1/src/wp-admin/includes
 /class-wp-list-table.php#L1410

 Not sure why I felt `return;` was needed, removed in
 [https://core.trac.wordpress.org/attachment/ticket/44354/44354.5.diff
 44354.5.diff] as it's unnecessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44354#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list