[wp-trac] [WordPress Trac] #44266: Add per-request-row delete row action for privacy actions

[WordPress Trac]

#44266: Add per-request-row delete row action for privacy actions
-------------------------------------------------+-------------------------
 Reporter:  allendav                             |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:  ui
  screenshots                                    |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-testing has-screenshots needs-refresh => has-
     patch needs-testing has-screenshots
 * owner:  xkon => garrett-eclipse
 * focuses:   => ui
 * status:  assigned => accepted
 * milestone:  Future Release => 5.6


Comment:

 Good point @xkon, I've refreshed in
 [https://core.trac.wordpress.org/attachment/ticket/44266/44266.5.diff
 44266.5.diff] and feel it's pretty well there so am moving to 5.6 for
 extra eyes. Please take a minute to test if you can.

 I've gone with the following verbiage which is clear enough but not overly
 verbose;
 `Download Data | Resend Confirmation | Delete Request`
 `Force Erasure | Resent Confirmation | Delete Request`

 As to the URI and leaving param remnants during requests I adopted the
 posts/comments approach to using a sendback and redirect. To handle the
 redirect there's now a new `handle_bulk_messages` function that takes the
 info params from the redirect to display the message. This strips the
 wpnonce and other undesired items.

 One drawback of the sendback method was the split mean passing the request
 id in order for us to lookup the email, but on delete actions the request
 is gone so we can't do the lookup. The only workaround is to pass the
 email via the param and I'd prefer not to have email in URL as that's
 saved to history etc. So instead for delete we only provide the count and
 not the email. The resent we do provide email as it's more important to
 know who was resent to than who you deleted.

 Please test and review and let's move this forward.

 P.S. One issue you may note, especially locally testing, is failed request
 emails aren't reported. I'm looking to address that via #44081.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44266#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform