[wp-trac] [WordPress Trac] #46986: DNT Parameter automatically for Vimeo oEmbed requests

[WordPress Trac]

#46986: DNT Parameter automatically for Vimeo oEmbed requests
-------------------------------------------------+-------------------------
 Reporter:  djc71889                             |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Embeds                               |     Version:  4.9
 Severity:  major                                |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:  privacy
  note has-unit-tests                            |
-------------------------------------------------+-------------------------
Changes (by Mista-Flo):

 * keywords:  has-patch needs-testing needs-unit-tests needs-dev-note =>
     has-patch needs-testing needs-dev-note has-unit-tests


Comment:

 Hi there,

 thanks for your patch @garrett-eclipse, I have uploaded another patch to
 fix the if state, the code was doing the opposite of what we wanted. It
 was adding the dnt attribute only to vimeo oembeds.

 I have also added one unit test, but I am not sure it's a good one, I have
 copy pasted the URL of a public video from vimeo.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46986#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform