[wp-trac] [WordPress Trac] #46986: DNT Parameter automatically for Vimeo oEmbed requests

WordPress Trac noreply at wordpress.org
Wed Oct 7 19:13:56 UTC 2020


#46986: DNT Parameter automatically for Vimeo oEmbed requests
-------------------------------------------------+-------------------------
 Reporter:  djc71889                             |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Embeds                               |     Version:  4.9
 Severity:  major                                |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:  privacy
  tests needs-dev-note                           |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  2nd-opinion needs-patch => has-patch needs-testing needs-unit-
     tests needs-dev-note
 * owner:  (none) => garrett-eclipse
 * version:   => 4.9
 * status:  new => accepted
 * type:  enhancement => defect (bug)


Comment:

 In [https://core.trac.wordpress.org/attachment/ticket/46986/46986.diff
 46986.diff] I've made an initial patch on a simplistic approach focused on
 vimeo.com `dnt`.

 The `dnt` setup is followed by the `oembed_fetch_url` which allows you to
 update the oembed `$provider` already. So instead of a new filter I just
 provided a `@since` update and function example for how users can re-
 enable `dnt` for `vimeo.com` now that we've excluded that one provider
 specifically.

 Please test not only the change but also the function example.

 I added `needs-unit-tests` but am unsure if that's necessary but may be
 helpful in confirming dnt is not present on vimeo.com urls. This will
 though need a dev note.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46986#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list