[wp-trac] [WordPress Trac] #42692: Unused static variable $column_headers
WordPress Trac
noreply at wordpress.org
Tue Oct 6 05:29:26 UTC 2020
#42692: Unused static variable $column_headers
--------------------------+-----------------------------
Reporter: jlambe | Owner: (none)
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: General | Version:
Severity: normal | Resolution: wontfix
Keywords: close | Focuses: administration
--------------------------+-----------------------------
Changes (by talldanwp):
* keywords: close dev-feedback => close
* status: new => closed
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
Hi @jlambe, this ticket was mentioned during a triage session in slack
(https://wordpress.slack.com/archives/C02RQBWTW/p1601961287272200). None
of us present were particularly familiar with this bit of code, but I
found the relevant changes in the project history which might shed some
light.
This is the commit:
https://github.com/WordPress/wordpress-
develop/commit/3940109c7f1d62bff1034a8121773fa5662c8c2b
And here is the ticket for the change:
https://core.trac.wordpress.org/ticket/18785
It seems as though there was a need to retain backward compatibility,
which may be why the variable is marked as static.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42692#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list