[wp-trac] [WordPress Trac] #25473: wp_text_diff creates wrong number of columns if title arguments are set

[WordPress Trac]

#25473: wp_text_diff creates wrong number of columns if title arguments are set
-------------------------------------------------+-------------------------
 Reporter:  joedolson                            |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Revisions                            |     Version:  3.6.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-design-feedback      |     Focuses:
  needs-design needs-screenshots                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 Refresh against trunk in [attachment:"25473.3.diff"]

 Here are some screenshots as you requested @melchoyce - I tested with
 trunk to document the current state/issue:

 I added some css border lines to the table (`table.diff td{ border: 1px
 dotted lightgray; }`) so the issue is more apparent.

 https://share.getcloudapp.com/o0umkyvN

 Using the filter and adding a title:
 https://share.getcloudapp.com/wbuPJ1P8

 Adding only title_left: (missing column)
 https://share.getcloudapp.com/8Lurdm5G

 Also problematic with table_right:
 https://share.getcloudapp.com/X6udYW8k

 Show split screen false by default looks good:
 https://share.getcloudapp.com/5zuwDWPm

 Adding the title or left/right messes the display up:
 https://share.getcloudapp.com/bLuwJ6yr

 https://share.getcloudapp.com/bLuwJ6Qr

 I'm going to review and review the current patch to see if fixes all these
 layouts, I think the work diverged here to addressing the removed/added
 column confusion which is a somewhat separate issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/25473#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform