[wp-trac] [WordPress Trac] #50683: Parse content for shortcodes instead of using regex

WordPress Trac noreply at wordpress.org
Fri Oct 2 01:12:20 UTC 2020


#50683: Parse content for shortcodes instead of using regex
--------------------------------------+-----------------------------
 Reporter:  cfinke                    |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.6
Component:  Shortcodes                |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------

Comment (by cfinke):

 Thanks for the nudge @johnbillion. I'll upload a new patch now. I've
 removed the debug code from the class, double-checked the inline docs
 (although I didn't add @since, since I'm not sure what it should be), and
 included the test files I used for my speed benchmarking in the patch.

 To just run the speed test, run `phpunit --group shortcode --filter
 test_speed`. It's not actually a test case, but it was the easiest way I
 knew to run the speed tests from the command line.  To compare with the
 current implementation, you'd need to run that command on both the patched
 and unpatched WordPress code and compare the times that get output.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50683#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list