[wp-trac] [WordPress Trac] #46911: iframe in update-core.php

[WordPress Trac]

#46911: iframe in update-core.php
-----------------------------+---------------------------------
 Reporter:  madivad          |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  5.1.1
 Severity:  minor            |  Resolution:
 Keywords:                   |     Focuses:  ui, administration
-----------------------------+---------------------------------

Comment (by tim.wakeling):

 This is a fairly significant issue actually, because sometimes the last
 text you can see is the text with the "..." which indicates the process is
 still ongoing, when it isn't. It's not clear there is an iframe with a
 scrollbar at all, and I have often missed it. The links to go back are
 also hidden below the bottom if the content exceeds the height.

 Is the solution perhaps to make the height of the iframe calc( 100vh -
 84px ) instead of 100%? The 84px is made up of 42px for the height of the
 "Update Plugins" heading, the margin on the wrap div, and the height of
 the admin bar at the top. I daresay these can and perhaps should be
 calculated relatively but I'm not quite sure. Though having the iframe
 larger than the total height isn't a huge problem is it? So maybe just
 100vh is fine.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46911#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform