[wp-trac] [WordPress Trac] #51822: Ensure update-core.php knows you're using a development version

[WordPress Trac]

#51822: Ensure update-core.php knows you're using a development version
----------------------------------------------+-----------------------
 Reporter:  afragen                           |       Owner:  audrasjb
     Type:  defect (bug)                      |      Status:  accepted
 Priority:  normal                            |   Milestone:  5.6
Component:  Upgrade/Install                   |     Version:  5.6
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:
----------------------------------------------+-----------------------

Comment (by azaozz):

 Perhaps I'm overthinking it a bit but to identify a `beta` or `RC`
 "channel", the code currently sets the type of update before making the
 wp.org API request, and then checks/expects that `$updates[0]->response`
 is `'development'`. The same is used in `core_upgrade_preamble()`,
 `core_update_footer()`, `list_core_update()` (twice),
 `wp_get_update_data()`.

 Then 51822.3.diff changes only `core_upgrade_preamble()` to use
 `$wp_version` instead, which makes it a bit inconsistent. What happens if
 there's an edge case/error with the request and the wp.org API doesn't
 return `'development'`? Seems that perhaps the Beta Tester plugin could be
 extended to handle this case better.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51822#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform