[wp-trac] [WordPress Trac] #51871: Site Health actions that use the REST API receive an untranslated response

WordPress Trac noreply at wordpress.org
Fri Nov 27 20:03:37 UTC 2020


#51871: Site Health actions that use the REST API receive an untranslated response
--------------------------+--------------------------------
 Reporter:  oglekler      |       Owner:  TimothyBlynJacobs
     Type:  defect (bug)  |      Status:  assigned
 Priority:  high          |   Milestone:  5.6
Component:  Site Health   |     Version:  5.6
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  rest-api
--------------------------+--------------------------------
Changes (by TimothyBlynJacobs):

 * keywords:  has-patch =>
 * priority:  normal => high


Comment:

 Yeah I misread the ticket the first time. We still need to fix that issue,
 and I've attached a patch that will handle that part.

 I believe this specific issue is because the strings are defined in the
 `WP_Site_Health` class which is in `wp-admin` so part of the admin
 language pack. But the REST API executes in a front-end context, so those
 admin translations aren't loaded by `load_default_textdomain`. I'm not
 sure what should be done about that.

 Cc: @ocean90, @swissspidy, @SergeyBiryukov.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51871#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list