[wp-trac] [WordPress Trac] #51612: `render_block_data` for nested blocks - WP_Block::render vs render_block
WordPress Trac
noreply at wordpress.org
Tue Nov 24 13:34:11 UTC 2020
#51612: `render_block_data` for nested blocks - WP_Block::render vs render_block
--------------------------------------+-------------------------
Reporter: gaambo | Owner: noisysocks
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.6
Component: Editor | Version: 5.5
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-------------------------
Comment (by TimothyBlynJacobs):
I think this should probably be reverted and tried again in 5.7-early.
This has more ramifications than was previously thought, that should be
resolved in Beta not RC.
> When it is instantiated it has unfiltered (wrong?) data
IMO this isn't incorrect data. I think it would be incorrect if the render
filters were used when the block wasn't in a render context. I think this
is analogous to `WP_Post::filter` and `WP_Term::filter`. Maybe we should
make the `WP_Block` follow that filter API pattern instead to be more
clear.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51612#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list