[wp-trac] [WordPress Trac] #48782: Fix link-manager styles

WordPress Trac noreply at wordpress.org
Mon Nov 23 05:32:57 UTC 2020


#48782: Fix link-manager styles
-------------------------------------------------+-------------------------
 Reporter:  antonlukin                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.7
Component:  Posts, Post Types                    |     Version:  5.3
 Severity:  minor                                |  Resolution:
 Keywords:  has-screenshots good-first-bug has-  |     Focuses:  ui, css
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * milestone:  Future Release => 5.7


Comment:

 Thanks for the PR @grzim! The styles look good on the Add New Link page,
 but the `.inside` top margin is still only 6 pixels on the Edit Link page
 instead of 12.

 Here are a few suggestions:
 1. Include `.link-php #poststuff .inside` for the override (or else add a
 new class to the first div within the form element on both pages).
 2. Move this style override after `#poststuff .inside`.
 3. Only specify the top margin for the `.link-php` and `.link-add-php`
 styles.
 4. Simplify the existing shorthand for `#poststuff .inside`.

 {{{
 #poststuff .inside {
         margin: 6px 0 0;
 }

 .link-php #poststuff .inside,
 .link-add-php #poststuff .inside {
         margin-top: 12px;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48782#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list