[wp-trac] [WordPress Trac] #51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it causes a PHP Warning to be thrown.

[WordPress Trac]

#51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it
causes a PHP Warning to be thrown.
---------------------------------------+-----------------------
 Reporter:  jamesros161                |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  closed
 Priority:  highest omg bbq            |   Milestone:  5.6
Component:  Upgrade/Install            |     Version:  5.6
 Severity:  normal                     |  Resolution:  fixed
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------
Changes (by azaozz):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"49677" 49677]:
 {{{
 #!CommitTicketReference repository="" revision="49677"
 Upgrade/Install: Replace the conditionals that check the
 `AUTOMATIC_UPDATER_DISABLED` constant and the `automatic_updater_disabled`
 filter in update-core.php with a call to
 `WP_Automatic_Updater::is_disabled()`. This prevents a PHP warning, fixes
 the logic, and considers `wp_is_file_mod_allowed( 'automatic_updater' )`
 when determining the UI state.

 Props jamesros161, pbiron, audrasjb, azaozz.
 Fixes #51827.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51827#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform