[wp-trac] [WordPress Trac] #51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it causes a PHP Warning to be thrown.

[WordPress Trac]

#51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it
causes a PHP Warning to be thrown.
-------------------------------------------------+-------------------------
 Reporter:  jamesros161                          |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  highest omg bbq                      |   Milestone:  5.6
Component:  Upgrade/Install                      |     Version:  5.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch 2nd-       |     Focuses:
  opinion needs-testing                          |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:15 pbiron]:
 > [attachment:"51827.2.patch"] tests correctly for me.

 Thanks!

 > you'll get a `Sorry, you are not allowed to access this page.` error
 from WP...that is to be expected, since the Updates screen is not allowed
 when file mods are disallowed :-)

 Right. Checking `wp_is_file_mod_allowed()` there is mostly for
 completeness. In theory a plugin would be able to use the
 `file_mod_allowed` filter and allow loading of the Update screen even when
 `DISALLOW_FILE_MODS` is defined and true.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51827#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform