[wp-trac] [WordPress Trac] #51822: Ensure update-core.php knows you're using a development version

[WordPress Trac]

#51822: Ensure update-core.php knows you're using a development version
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Upgrade/Install                      |     Version:  5.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots dev-       |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Thanks for the ticket and the patch!

 Just noting that in my testing the results were initially a bit different
 from the screenshots here.

 Without the Beta Tester plugin:
 * On 5.6-RC1: "An updated version of WordPress is available."
 * On 5.6-RC1-49652: "You are using a development version of WordPress."
 * On 5.7-alpha-49651: "You are using a development version of WordPress."

 This all actually seems accurate and follows one of the goals of [49638]:
 > Ensures only one heading between `update available`, `you are on a dev
 version`, and `you are on latest` appears at any given time, falling back
 to `you are on latest` if something strange happens with the returned
 update data.

 So it looks like the regression here is that when there is an update
 available, you no longer get the "You are using a development version of
 WordPress" message, but that was the intention of [49638].

 However, with the Beta Tester plugin (set to the `Beta/RC Only` stream as
 noted) the messages are indeed different and don't mention the development
 version, because in this case `$updates[0]->response` appears to be
 `latest` rather than `development`:
 * On 5.6-RC1: "You have the latest version of WordPress."
 * On 5.6-RC1-49652: "You have the latest version of WordPress."
 * On 5.7-alpha-49651: "You have the latest version of WordPress."

 This seems like a larger regression.

 Without the plugin, [attachment:"51822.2.diff"] doesn't seem to make any
 difference, the messages are still the same, because "An updated version
 of WordPress is available" message has the higher priority.

 With the plugin, [attachment:"51822.2.diff"] does fix the issue and
 displays "You are using a development version" in all three cases.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51822#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform