[wp-trac] [WordPress Trac] #51723: App Passwords: Regenerate .htaccess for 5.6
WordPress Trac
noreply at wordpress.org
Tue Nov 17 17:12:33 UTC 2020
#51723: App Passwords: Regenerate .htaccess for 5.6
------------------------------------+--------------------------------
Reporter: TimothyBlynJacobs | Owner: TimothyBlynJacobs
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.6
Component: Login and Registration | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: rest-api
------------------------------------+--------------------------------
Comment (by SergeyBiryukov):
Replying to [comment:9 pbiron]:
> since `save_mod_rewrite_rules()` is **not** defined at the time
`flush_rewrite_rules()` is called when `db_updated` is checked, the flush
there has **never** been a "hard" flush. Based on what sergey said in
that thread, I figure that was "bug"...which is fixed by that patch.
Yeah, I guess this was never noticed because `.htaccess` changes are rare,
the last one was 11 years ago in [13676].
> So, when/if we come back to this in a future version, ''maybe'' there's
a way we can indicate (in the value for the `db_updated` option) whether a
"hard" flush is needed and do the `require_once` before calling
`flush_rewrite_rules()` only in that case.
I think [attachment:"51723.2.diff"] should be fine as is even without the
additional indication.
This could, however, use some better documentation. Created #51805 for
that :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51723#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list