[wp-trac] [WordPress Trac] #51317: Remove deprecated JavaScript i18n globals
WordPress Trac
noreply at wordpress.org
Tue Nov 17 04:43:49 UTC 2020
#51317: Remove deprecated JavaScript i18n globals
----------------------------+-----------------------------
Reporter: SergeyBiryukov | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Script Loader | Version: 5.5.1
Severity: normal | Resolution:
Keywords: 5.7-early | Focuses: javascript
----------------------------+-----------------------------
Comment (by noisysocks):
In [changeset:"49625" 49625]:
{{{
#!CommitTicketReference repository="" revision="49625"
Customize: Temporary fix for autosave restore notice not being removed
Fixes the "There is a more recent autosave of your changes" notice from
not
being removed when the dismiss button is clicked.
The problem is caused by the notice being initialized twice: once by the
`common` script and then again by the `customize-controls` script.
This temporary fix prevents `customize-controls` from initializing a
notice if
it has already been initialized.
A better fix would be to not initialize notices twice. This can be done by
removing `common` as a dependency of `updates` when `deprecateL10nObject`
is
removed.
When this happens (est: 5.7), this temporary fix should be reverted.
Fixes #51425.
See #51317.
Props karthikbhatb, dlh, SergeyBiryukov.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51317#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list