[wp-trac] [WordPress Trac] #51425: Customizer Restore Autosave Notice dismiss function is not called

[WordPress Trac]

#51425: Customizer Restore Autosave Notice dismiss function is not called
-------------------------------------+-----------------------------
 Reporter:  karthikbhatb             |       Owner:  noisysocks
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.6
Component:  Customize                |     Version:  5.5
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:  ui, javascript
-------------------------------------+-----------------------------
Changes (by noisysocks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"49625" 49625]:
 {{{
 #!CommitTicketReference repository="" revision="49625"
 Customize: Temporary fix for autosave restore notice not being removed

 Fixes the "There is a more recent autosave of your changes" notice from
 not
 being removed when the dismiss button is clicked.

 The problem is caused by the notice being initialized twice: once by the
 `common` script and then again by the `customize-controls` script.

 This temporary fix prevents `customize-controls` from initializing a
 notice if
 it has already been initialized.

 A better fix would be to not initialize notices twice. This can be done by
 removing `common` as a dependency of `updates` when `deprecateL10nObject`
 is
 removed.

 When this happens (est: 5.7), this temporary fix should be reverted.

 Fixes #51425.
 See #51317.
 Props karthikbhatb, dlh, SergeyBiryukov.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51425#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform