[wp-trac] [WordPress Trac] #42140: Incorrect use of plural in class-wp-customize-themes-section.php

[WordPress Trac]

#42140: Incorrect use of plural in class-wp-customize-themes-section.php
-------------------------------------------------+-------------------------
 Reporter:  tobifjellner                         |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.7
Component:  Customize                            |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:  javascript
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * milestone:  Future Release => 5.7


Comment:

 Just noting this would be consistent with the work done for some other
 scripts in 5.5:
 https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5

 The patch looks mostly good at a glance, a few notes though:
 * Any strings with placeholders need to keep their translator comments.
 * In `wp-includes/customize/class-wp-customize-themes-section.php`, the
 `_n()` usage is incorrect: the third argument should be a number, not a
 string.
 * In `js/_enqueues/wp/customize/controls.js`, It looks like
 `countEl.text()` now receives a `%s themes` string instead of just a
 number, but the associated container still has the same string, so it
 might be duplicated. This needs some testing.

 Let's clean this up a bit in 5.7.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42140#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform