[wp-trac] [WordPress Trac] #29159: Classic editor: Visual editor is disabled when user agent is obscured by a proxy (was: user-agent checking is removing visual editor in function user_can_richedit)

[WordPress Trac]

#29159: Classic editor: Visual editor is disabled when user agent is obscured by a
proxy
-------------------------------------------------+-------------------------
 Reporter:  vmuryginIB                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Editor                               |     Version:  2.0
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by noisysocks):

 * keywords:  reporter-feedback => needs-testing has-patch needs-unit-tests
 * milestone:  Awaiting Review => Future Release


Comment:

 Defaulting to enabled makes sense in my mind. Most browsers support the
 classic visual editor. We should only disable when we ''know'' that the
 user's browser doesn't support the classic visual editor.

 I added [attachment:"29159.diff"] which makes `true` the default. Testing
 is needed to ensure that `user_can_richedit`:

 - Returns `true` when browser is Edge, Chrome, etc.
 - Returns `true` when browser is IE 11
 - Returns `true` when user agent is something like "Amazon CloudFront"
 - Returns `false` when browser is < IE 11
 - Returns `false` when browser is Mobile Safari < 534

 Unit tests should be added.

 Note that the block editor is always enabled. This only affects users with
 the Classic Editor plugin.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/29159#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform