[wp-trac] [WordPress Trac] #51723: App Passwords: Regenerate .htaccess for 5.6

[WordPress Trac]

#51723: App Passwords: Regenerate .htaccess for 5.6
------------------------------------+--------------------------------
 Reporter:  TimothyBlynJacobs       |       Owner:  TimothyBlynJacobs
     Type:  task (blessed)          |      Status:  reopened
 Priority:  normal                  |   Milestone:  5.6
Component:  Login and Registration  |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch commit        |     Focuses:  rest-api
------------------------------------+--------------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-patch => has-patch commit
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 It was pointed out by @pbiron in
 [https://wordpress.slack.com/archives/C02RQC26G/p1605285775446300 #core-
 restapi] that the `.htaccess` file was not updated after [49534].

 While `WP_Rewrite::flush_rules()` gets called after a DB version bump, it
 only calls `save_mod_rewrite_rules()` if the function exists, however the
 function is only loaded via `wp-admin/includes/admin.php` exactly after
 the `flush_rewrite_rules()` call in [source:tags/5.5.3/src/wp-
 admin/admin.php?marks=40#L38 wp-admin/admin.php], so we do need an upgrade
 routine here.

 For reference, it's been a while since we've added or updated `.htaccess`
 rules: [2635], [3401], [13676].

 [attachment:"51723.diff"] works as expected in my testing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51723#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform