[wp-trac] [WordPress Trac] #36392: wp_add_inline_script() breaks script dependency order when using script loader (no SCRIPT_DEBUG)
WordPress Trac
noreply at wordpress.org
Sat Nov 14 17:21:13 UTC 2020
#36392: wp_add_inline_script() breaks script dependency order when using script
loader (no SCRIPT_DEBUG)
---------------------------------------------+-------------------------
Reporter: westonruter | Owner: swissspidy
Type: defect (bug) | Status: closed
Priority: high | Milestone: 4.5
Component: Script Loader | Version: 4.6
Severity: major | Resolution: fixed
Keywords: has-unit-tests has-patch commit | Focuses:
---------------------------------------------+-------------------------
Comment (by johnbillion):
In [changeset:"49601" 49601]:
{{{
#!CommitTicketReference repository="" revision="49601"
Build/Test Tools: Improve the reliability of the test that ensures correct
dependency order when inline scripts are used.
This test already ensures `WP_Scripts->do_concat` is true, therefore it
has no dependency on `SCRIPT_DEBUG` being false. This means the test can
run in an environment where the `.min` suffix is not used.
This change allows for the test to pass in this situation.
See #36392, #51734, #51344
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36392#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list