[wp-trac] [WordPress Trac] #51742: Core auto-updates UI: disable checkbox when filter or constant takes precedent on the option

[WordPress Trac]

#51742: Core auto-updates UI: disable checkbox when filter or constant takes
precedent on the option
---------------------------------------+-----------------------
 Reporter:  audrasjb                   |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  5.6
Component:  Upgrade/Install            |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui
---------------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:42 audrasjb]:
 > `51742.10.diff` fixes this issue.

 Just a quick note that in [49592] I changed the value passed to the filter
 from `null` to `false`, for consistency with the corresponding
 [source:tags/5.5.3/src/wp-admin/includes/class-wp-site-health-auto-
 updates.php?marks=152,153#L144 Site Health check].

 I know we pass `null` to the `auto_update_{$type}` filter to detect
 whether nothing has hooked into it, as discussed in #50848, but in this
 case it looks like we just need to detect whether the updater is disabled
 or not, so passing `false` seems appropriate.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51742#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform