[wp-trac] [WordPress Trac] #51742: Core auto-updates UI: disable checkbox when filter or constant takes precedent on the option

[WordPress Trac]

#51742: Core auto-updates UI: disable checkbox when filter or constant takes
precedent on the option
---------------------------------------+-----------------------
 Reporter:  audrasjb                   |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  5.6
Component:  Upgrade/Install            |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui
---------------------------------------+-----------------------

Comment (by azaozz):

 Replying to [comment:38 helen]:
 > Consider adding a string for when major auto-updates are on but minor
 ones are off - IMO this is a strange and non-ideal thing to do, but is
 technically possible...

 Yeah, this doesn't make sense even though it's been technically possible.
 Logically, when turning major updates on, it should set minor updates to
 on too, i.e. enabling major updates will override minor updates to always
 "on".

 This is the same case as when `beta` or `rc` are set in the
 `WP_AUTO_UPDATE_CORE` constant, see:
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 core-upgrader.php#L287. So instead of adding a string, lets "fix" the
 logic there. True, this is a change (a logic enhancement?) to how the
 various "global" auto-update filters and constants work, but thinking now
 is the time to fix it.

 Plugins can block any update depending on the "offered version" with the
 `auto_update_[core]` filter:
 https://core.trac.wordpress.org/browser/tags/5.5.3/src/wp-admin/includes
 /class-wp-automatic-updater.php#L178, see the `$item` param. It is
 possible to fully control which updates are automatically applied without
 even looking at the "global settings" in options, constants, and other
 filters.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51742#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform