[wp-trac] [WordPress Trac] #51742: Core auto-updates UI: disable checkbox when filter or constant takes precedent on the option

[WordPress Trac]

#51742: Core auto-updates UI: disable checkbox when filter or constant takes
precedent on the option
-------------------------------------------------+-------------------------
 Reporter:  audrasjb                             |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  ui
  copy-review dev-feedback needs-testing         |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:25 audrasjb]:
 > Just added `51742.6.diff` which updates your patch to also give
 precedence to `AUTOMATIC_UPDATER_DISABLED`

 Thanks, looks good :)

 There's some more: we changed the values saved in the DB for the new
 options (`auto_update_core_dev`, `auto_update_core_minor`, and
 `auto_update_core_major`) to avoid PHP type juggling, but the filtered
 values for `allow_dev_auto_core_updates`, `allow_minor_auto_core_updates`,
 and `allow_major_auto_core_updates` filters would still need to be boolean
 as these filters have existed since 2013. Patch coming up.

 Also all new options have to be added to `populate_options()` to avoid
 making extra calls to the DB for non-existing options. Will update the
 patch on #51743.

 Still todo: test in multisite/network in both existing and new installs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51742#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform