[wp-trac] [WordPress Trac] #51742: Core auto-updates UI: disable checkbox when filter or constant takes precedent on the option

[WordPress Trac]

#51742: Core auto-updates UI: disable checkbox when filter or constant takes
precedent on the option
-------------------------------------------------+-------------------------
 Reporter:  audrasjb                             |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  ui
  copy-review needs-design-feedback dev-         |
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:9 audrasjb]:

 Looking at 51742.3.diff, see couple of problems and have few (nitpick)
 suggestions :)

 1. `core_auto_updates_settings()` should use a nonce when saving the
 options. As it's a link now the `core-auto-updates-major` query arg and
 the nonce will be in the `$_GET` which is not ideal (if the user bookmarks
 the page while `?core-auto-updates-major=...` is in the URL, it will try
 to set the option every time they use that bookmark). To fix that it
 should use `wp_nonce_url()` and then immediately redirect after the option
 is updated (for example see how "action links" in list tables work).

 2. The filter `allow_major_auto_core_updates` runs two times in a row.
 Perhaps that's a typo, it's pretty confusing and not sure it is necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51742#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform