[wp-trac] [WordPress Trac] #19709: Add 'before_sidebar' and 'after_sidebar' attributes to register_sidebar()

WordPress Trac noreply at wordpress.org
Tue Nov 10 20:35:28 UTC 2020


#19709: Add 'before_sidebar' and 'after_sidebar' attributes to register_sidebar()
--------------------------------------+-----------------------
 Reporter:  dgwyer                    |       Owner:  audrasjb
     Type:  task (blessed)            |      Status:  reopened
 Priority:  high                      |   Milestone:  5.6
Component:  Widgets                   |     Version:  2.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+-----------------------

Comment (by helen):

 Just want to be sure I'm understanding here - we are potentially reusing
 the `id` and `class` params for the `before_sidebar` element? I don't
 think this is inherently a problem because it's empty by default but this
 is leading developers into a situation where two elements have the same
 ID, which is not valid. I will fix the other issue, but I was also editing
 the documentation to include what's made available through `sprintf()` and
 that occurred to me.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/19709#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list