[wp-trac] [WordPress Trac] #43113: Multiple custom item classes are returned as single string when using 'nav_menu_link_attributes' filter with Customizer preview

WordPress Trac noreply at wordpress.org
Tue Nov 10 06:29:16 UTC 2020


#43113: Multiple custom item classes are returned as single string when using
'nav_menu_link_attributes' filter with Customizer preview
---------------------------------------------+-----------------------------
 Reporter:  lrdn                             |       Owner:  noisysocks
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  Future Release
Component:  Customize                        |     Version:  4.3
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-----------------------------
Changes (by noisysocks):

 * keywords:  has-patch has-unit-tests needs-testing needs-refresh => has-
     patch has-unit-tests commit


Comment:

 I attached:

 - [attachment:"43113.2.diff"] which is a refresh of
 [attachment:"43113.diff"], and;
 - [attachment:"43113.3.diff"] which uses `! is_array()` instead of
 `is_string()`.

 Both patches fix the bug locally and LGTM.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43113#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list