[wp-trac] [WordPress Trac] #51678: [5.6 Beta] Performance regression with i10n changes when translations files are not present

WordPress Trac noreply at wordpress.org
Mon Nov 9 15:07:52 UTC 2020


#51678: [5.6 Beta] Performance regression with i10n changes when translations files
are not present
-------------------------------------------------+-------------------------
 Reporter:  vedjain                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  high                                 |   Milestone:  5.6
Component:  I18N                                 |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing dev-feedback has-      |     Focuses:
  patch                                          |  performance
-------------------------------------------------+-------------------------

Comment (by ocean90):

 @vedjain Can you please submit your patches as a PR? This should also show
 you that it will break a few tests. It's still not clear what exactly
 you're testing and how it's related to the `is_readable()` line which
 isn't new.

 [https://github.com/WordPress/wordpress-develop/pull/707 PR707] restores
 some static caching which we had before to reduce some `load_textdomain()`
 calls. Initially it's still called once. If we don't want this either we
 could also restore `_get_path_to_translation_from_lang_dir()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51678#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list