[wp-trac] [WordPress Trac] #51727: REST:API One of the new strings should use _n()
WordPress Trac
noreply at wordpress.org
Sat Nov 7 21:48:08 UTC 2020
#51727: REST:API One of the new strings should use _n()
--------------------------+-----------------------------
Reporter: tobifjellner | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.6
Component: REST API | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+-----------------------------
Comment (by SergeyBiryukov):
Some notes on the patch:
* Translator comment should be directly above the line with the `_n()`
call, not earlier.
* `_n()` should receive the number as is, `number_format_i18n()` is only
needed in the second instance.
* As noted above, needs some PHPCS corrections.
Looks good otherwise :) This can all be corrected on commit.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51727#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list