[wp-trac] [WordPress Trac] #51256: Duplicate HTML IDs for checkboxes in Plugins list table
WordPress Trac
noreply at wordpress.org
Sat Nov 7 21:09:01 UTC 2020
#51256: Duplicate HTML IDs for checkboxes in Plugins list table
----------------------------+-----------------------------
Reporter: SergeyBiryukov | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.6
Component: Plugins | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: administration
----------------------------+-----------------------------
Comment (by sabernhardt):
Thanks for the patch and the refresh. [attachment:"51256.3.diff"] works
for me on the Plugins screen.
{{{
<label class="screen-reader-text"
for="checkbox_3775c0de7d0f58c2defbc4e193e54702">Select Widget
Options</label>
<input type="checkbox" name="checked[]" value="widget-options/plugin.php"
id="checkbox_3775c0de7d0f58c2defbc4e193e54702" />
<label class="screen-reader-text"
for="checkbox_5e234580d0aeec7d9f5df882c7233442">Select Widget
Options</label>
<input type="checkbox" name="checked[]" value="widget-options2/plugin.php"
id="checkbox_5e234580d0aeec7d9f5df882c7233442" />
}}}
We probably should do the same for the [source:trunk/src/wp-admin/update-
core.php?rev=49490#L509 update-core page], replacing `$plugin_data->Name`
with `$plugin_file`. Would opening a separate ticket for that be better
than adding it here?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51256#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list