[wp-trac] [WordPress Trac] #48301: Backport the simplified local environment

[WordPress Trac]

#48301: Backport the simplified local environment
------------------------------+-----------------------------
 Reporter:  desrosj           |       Owner:  desrosj
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  Future Release
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  needs-testing has-patch has-unit-tests => has-patch
 * type:  enhancement => task (blessed)


Comment:

 I've spent a huge amount of time on this the last few months. I'd like to
 wrap this up, and I think we're in a state where we can backport . It's a
 blocker for backporting the GitHub action workflows to older branch, which
 will is a huge step towards finishing a transition off Travis CI.

 I've resolved almost all of the issues above. A large number of them were
 being caused by missing packages or incorrect configurations within the
 Docker containers (mainly for PHP 5.4 and earlier).

 The one remaining issue is that the PHP 5.2 Docker container is not yet
 able to be used. For more information on that, see the
 [https://github.com/WordPress/wpdev-docker-images/pull/46 ongoing GitHub
 PR] (TLDR: WP-CLI does not support PHP 5.2, and the PHPUnit test suite
 requires version 3.6 on PHP 5.2, which is no longer available). **For the
 time being, the 5.2 jobs will continue using Travis' precise image, and
 will not be switched to use the Docker container.**

 **Here is a list of remaining blockers:**

 #46073/[45067]: This was resolved in the 5.2 branch. This will need to be
 backported all the way to 3.7. Because the Travis environment does not
 include the needed Imagick components, the related tests are always
 skipped. But when the tests shift to being run within the Docker
 container, Imagick is present and this error presents itself.

 [48486]: This change backported some error detection within tests
 confirming PDF thumbnail generation functionality to the 5.0 branch.
 However, the variable name within the
 `test_pdf_preview_doesnt_overwrite_existing_jpeg()` test was inadvertently
 incorrect. Similar to the last item, this test function was never reached
 because of a lack of the presence of Imagick. Within the Docker container,
 it now causes a test error. This needs to be committed to 5.0 and
 backported to the 4.7 branch.

 #51624: This fixes a compatibility issue with Composer 2.0. This has been
 backported to the 5.3 branch, but it looks like it will also need to be
 merged back through 5.1 because `composer.json`/`composer.lock` files are
 present. The `travis:format` command does call `composer` to check for
 coding standards issues, but it does so within the Travis image, which
 still runs Composer 1.x. When the Docker container is backported, this
 will now run within the container, which has Composer 2.0.

 Because the PHP_CodeSniffer is updated as a result of this fix, there are
 a few minor, spacing and alignment coding standards issues that will be
 flagged during the code base scan. I have included these fixes in the PRs,
 and they should be OK to make/include in the next release for the 5.2 and
 5.1 branches. The total number is 6 files with coding standards changes,
 which should not cause issues with auto-updates.

 Problems with old Node versions: In the 4.5 and lower branches, the
 version of NodeJS required drops to NodeJS < 6. This becomes problematic
 because the required versions of the `dotenv`, `dotenv-expand`, `wait-on`
 NPM packages do not support these older versions of NodeJS. I'd like to
 take a step back and look holistically at NodeJS in older branches. This
 has been discussed in 51603#comment:15 (see also #51682, #48140).

 **Today's Plan**
 My plan for after this comment is to backport everything outlined today
 back to the 4.6 branch (all open PRs above). After that, we can solve the
 NodeJS problem, and finish backporting.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48301#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform